Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remapping the output topic of image_publisher is not effective #839

Closed
meyerj opened this issue Oct 27, 2023 · 2 comments
Closed

Remapping the output topic of image_publisher is not effective #839

meyerj opened this issue Oct 27, 2023 · 2 comments
Assignees

Comments

@meyerj
Copy link

meyerj commented Oct 27, 2023

If I run the following command with the binary installation of ROS Humble in Ubuntu 22.04:

$ ros2 run image_publisher image_publisher_node --ros-args -p filename:=logo.jpg -r image_raw:=foo/image_raw

with a remapping of the hard-coded default namespace image_raw to some other name, foo/image_raw, the remapping only has an effect for the raw image topic, but not for the camera_info, compressed and theora topics exposed by image_transport plugins:

$ ros2 node info /ImagePublisher
/ImagePublisher
  Subscribers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
  Publishers:
    /camera_info: sensor_msgs/msg/CameraInfo
    /foo/image_raw: sensor_msgs/msg/Image
    /image_raw/compressed: sensor_msgs/msg/CompressedImage
    /image_raw/compressedDepth: sensor_msgs/msg/CompressedImage
    /image_raw/theora: theora_image_transport/msg/Packet
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /rosout: rcl_interfaces/msg/Log
  Service Servers:
    /ImagePublisher/describe_parameters: rcl_interfaces/srv/DescribeParameters
    /ImagePublisher/get_parameter_types: rcl_interfaces/srv/GetParameterTypes
    /ImagePublisher/get_parameters: rcl_interfaces/srv/GetParameters
    /ImagePublisher/list_parameters: rcl_interfaces/srv/ListParameters
    /ImagePublisher/set_parameters: rcl_interfaces/srv/SetParameters
    /ImagePublisher/set_parameters_atomically: rcl_interfaces/srv/SetParametersAtomically
  Service Clients:

  Action Servers:

  Action Clients:

Is there any other way to publish an image on an arbitrary topic with the image_publisher node?

That behavior may be related to ros-perception/image_common#187 and affect all users of image_transport::CameraPublisher? If yes, this may also be the root cause of other issues, like #824.

Furthermore the default node name, ImagePublisher, with capitals and not anonymized is unexpected, because it does not follow typical naming conventions (not sure whether there is a REP or other kind of specification on that).

@mikeferguson
Copy link
Member

mikeferguson commented Jan 17, 2024

This does appear to be be an issue in image_transport for all but the raw plugin... I'm still trying to figure out exactly where it's going wrong (because the linked issue is actually been temporarily patched AFAICT)

@mikeferguson mikeferguson self-assigned this Jan 18, 2024
@mikeferguson
Copy link
Member

Ok - so actually - it looks like we CAN fix this in image_pipeline - and actually, we should fix it here - by passing the fully remapped name as the base name. PR that fixes just this node: #851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants