-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate documentation #41
Comments
Grand theory of documentation: https://diataxis.fr/ |
Proposal for restructured real-time documentation at docs.ros.org: Tutorials
How-To-Guides
Concepts
|
Updated the Real-Time Documentation for ROS 2 document. Please review and add further existing pages in the table in section "Current status". Some items in the new proposed structure contain already a link to an existing pages. |
I wouldn't merge these two. Keeping the "Building ROS 2 with Tracing Instrumentation" as a standalone guide allows us to link to just that from anywhere. We could of course mention the other guide at the end as a logical follow-up guide. Edit: also, we want to enable instrumentation by default (ros2/ros2#1177), so the first guide will eventually not be required in order to follow the second guide. |
I think Pendulum Demo and Real-time Application configuration could be merged into one (heavily-rewritten) tutorial. The Pendulum could serve as the hello world program for real-time. |
Thank you very much for your active discussion in todays RTWG meeting. I updated our proposal for a consolidated real-time documentation. Next step would be, that we create and/or update the pages in our fork of ros2_documentation. |
Made an initial commit in the branch update-real-time in our fork of the ros2_documentation repository. I just created the subsection "Real-Time" and moved the existing pages there. Also added one page in Concepts section. I would propose, to first come up with a good outline in Develop-Real-Time-Application. |
Created real-time tutorial (using real-time threads): https://github.com/ros-realtime/ros2_documentation/blob/feature/update-real-time/source/Tutorials/Advanced/Real-Time/Real-Time-Processing-with-multiple-threads.rst Added code example to ros2-realtime-examples: ros-realtime/ros2-realtime-examples#10 |
@nightduck I think you mentioned during a RTWG meeting a few weeks ago that you were working on porting/moving the "How to use ros2_tracing to trace and analyze an application" tutorial to docs.ros.org. What is the status? I can help. |
Hi @christophebedard . We have not created any page yet. The idea is to have a seperate page about "ros2 tracing" outside the Tutorial/Advanced/RealTime tab. So, from my perspective, you can just go ahead. Any help very much appreciated. |
@christophebedard sorry for the late response, I was at a conference. The page has been ported, but we're not submitting a pull request until we've finished other modifications we're making. You can track our progress by monitoring that branch and the viewing the document @JanStaschulat linked Feb 9th:
|
The "How to use ros2_tracing to trace and analyze an application" tutorial doesn't really need to wait until everything else has been ported (it's better to make smaller PRs instead of a single big one), but sure, that's fine. |
@christophebedard , Yes, I agree. As the ros2_tracing tutorial will not be part of the Advanced/Tutorial/Realtime tab, you can go ahead and update the documentation in a separate PR. |
@nightduck do you want to do it, or should I? |
I can do it. Will ping you with the new PR later today
…On Tue, May 16, 2023, 12:50 PM Christophe Bedard ***@***.***> wrote:
@nightduck <https://github.com/nightduck> do you want to do it, or should
I?
—
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNQEJ6TDVJZWCVZVUICWDDXGO46BANCNFSM5YJDDQJA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@carlossvg @shuhaowu @nightduck I updated
Could you have a look and review? |
@JanStaschulat I didn't find a PR to add my comments so I will post them here in the meanwhile.
I would rephrase this. It sounds like we count the context switches for other processes different than the example.
I would clarify it is expected to see some involuntary context switches even with a real-time priority. There might be other threads with higher priority or interrupts preempting the real-time callback execution.
The link seems to be broken.
We should clarify this tutorial is specific for Linux.
I would clarify what we mean here with execution timing. Also, the term inherit could be misleading, it could be confusing when talking about middleware thread which could inherit the parent's thread scheduling attributes. We should probably mention what happens to those threads in this example. In this particular thread only the thread we create to spin the executor will have real-time priority while the middleware threads won't. |
@carlossvg (CC @christophebedard @nightduck @razr) Thank you for your review comments. I updated the tutorial accordingly. I created a pull request ros2/ros2_documentation#3756 but put it in DRAFT mode. I still need to write the tutorial with callack groups and I'd like to ask Andrei to update the operating systems tutorial. |
ros-realtime.github.io should be the only documentation website for the RTWG docs. Currently, there are different documents in separated github pages. We should consolidate all the documents in a single place so it's easier to find them.
The text was updated successfully, but these errors were encountered: