-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substantial Number of additional ROS2 Features Implemented on My Fork #123
Comments
Sorry, was a busy week. Hope I get the time to look at your branch next week. 35 changed files with 2427 additions and 277 deletions seems a lot for a singe PR. |
I have a lot of the work already split out into branches, it might be easier if I try to put some of the later fixes into those. I'll have a go on my end. Feel free to have a go at your end as well and see if we can't find a solution that works well. |
@hoffmann-stefan What do you think of Chootin/ros2_dotnet/upstream_pr1? It may still be too much; however this branch contains just the features relating to clock, timer, and the related fixes which I think should come first. Possibly what makes this look a little bigger than it is, is that I added |
@Chootin Jup this branch looks good for the next PR, Thanks :) Could you open it? |
PR is now available #124 |
As mentioned in a comment in my now merged pull request #122, I have implemented the following ROS2 features (as of writing) on my fork:
ros2 launch
andros2 run
These features have all been tested on two machines which are both running Ubuntu 20.04 and ROS2 Foxy. I have also been using them as part of the development of a Unity engine simulation toolkit here at QUT.
My Chootin/ros2_dotnet/dev branch (which contains all these features) is currently up-to-date with ros2_dotnet/main and can be automatically merged, so there should be two ways to contribute the code to the main repository.
Any thoughts @hoffmann-stefan or anyone else currently managing this repository?
Cheers, Alec.
The text was updated successfully, but these errors were encountered: