Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_tools] Update ROSCVMatContainer and do not convert color space of frames #623

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Draft

[image_tools] Update ROSCVMatContainer and do not convert color space of frames #623

wants to merge 1 commit into from

Conversation

Yadunund
Copy link
Member

Fix #612

This PR

  • Updates the ROSCvMatContainer to allow users to specify and override of the encoding string passed to sensor_msgs::Image. This is mostly for accurate visualization with rviz. Also updates cam2image appropriately.
  • Updates showimage to not perform any color space conversions to the frame. This is the actual fix to the issue

TODO: Test with hardware, remove comments and update tutorial doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 will be requested when the pull request is marked ready for review adityapande-1995 is a code owner

@audrow audrow Awaiting requested review from audrow audrow will be requested when the pull request is marked ready for review audrow is a code owner

@mjeronimo mjeronimo Awaiting requested review from mjeronimo mjeronimo will be requested when the pull request is marked ready for review mjeronimo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RGB order flipped when using cam2image with showimage
1 participant
@Yadunund