Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication plugin tests #318

Open
xabxx opened this issue Dec 6, 2018 · 1 comment
Open

authentication plugin tests #318

xabxx opened this issue Dec 6, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@xabxx
Copy link

xabxx commented Dec 6, 2018

Feature request

Add tests for node_creation success

test_security includes tests that target the authentication plugin. I see that it's making the node_creation fail when security env. variables are not set or are not set correctly. Perhaps we should also add the successful cases where a node is authentication and able to be created.

@clalancette clalancette added enhancement New feature or request help wanted Extra attention is needed labels Dec 19, 2018
@clalancette
Copy link
Contributor

Perhaps we should also add the successful cases where a node is authentication and able to be created.

That sounds like a reasonable test to me. Please consider opening a pull request implementing that test. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants