chore: fix broken build installing google chrome stable #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwr18
force-pushed
the
1343-fix-broken-build-installing-google-chrome-stable
branch
from
3630ba8 to
790fa32
Compare
- you must use the flag --allow-unauthenticated when running apt install with unauthenticated packages. Since we are not installing it in a Dockerfile, I'm not sure how to pass this flag in our travis.yml. Looking at the docs, it's not clear why we were installing it with apt though since they recommend using an addon. https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version
mattwr18
force-pushed
the
1343-fix-broken-build-installing-google-chrome-stable
branch
from
790fa32 to
15d62f9
Compare
- probably introduces breaking changes, but let's see what happens
roschaefer
approved these changes
Mar 9, 2020
|
Using gem |
roschaefer
deleted the
1343-fix-broken-build-installing-google-chrome-stable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow travis docs to install google-chrome-stable https://docs.travis-ci.com/user/chrome#selecting-a-chrome-version
Description
Fixes #1343