[WIP] 390 monthly email list revised #727
Conversation
There was a problem hiding this comment.
Awesome work 🥇
Here are a few suggestions for you. Also consider to try out some of the mail interceptor gems for rails: https://github.com/ryanb/letter_opener
https://mailcatcher.me/
mz99
force-pushed
the
390_monthly_email_list_revised
branch
2 times, most recently
from
1e8a1e6 to
a3772c3
Compare
mz99
force-pushed
the
390_monthly_email_list_revised
branch
from
a3772c3 to
72961c9
Compare
…oschaefer/rundfunk-mitbestimmen into 390_monthly_email_list_revised
backend/config/locales/de.yml
Outdated
| hello: Hallo | ||
| welcome: Willkommen zu den Updates dieses Monats: | ||
| body: | ||
| recently_created_broadcasts: Hier sind die neuen Sendungen, die seit Ihrer letzten Anmeldung den Rundfunk Mitbeständen hinzugefügt wurden: |
There was a problem hiding this comment.
Throughout the app we're using the informal, not very polite way of addressing "Du" instead of "Sie". The translation is perfect 👌 but very formal. I will fix the translations as soon as this PR is ready for merge
|
Nice work! @Kachulio1 and maybe @aonomike do you want to pair with @mz99 on this PR maybe? Pretty interesting stuff for you, I guess. I can chip tomorrow if you like. |
roschaefer
force-pushed
the
390_monthly_email_list_revised
branch
from
b271bc0 to
4c5ee5c
Compare
|
@mz99 It looks like the pending migrations are what is making the build fail. You might want to run them and see if the build passes. To resolve this issue, run: |
|
@faithngetich feel free to fix it yourself. There is no such thing as code ownership, but collective code ownership. The source branch of this PR is from our origin repository, so you should have write permissions. |
Since the last PR was accidentally merged already, here is the new branch. Should reasons_for_notifications be refactored to be more decoupled (separate each scenario into own methods)?
close #390