Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngTagInput #9

Open
anrepppp opened this issue Nov 29, 2016 · 4 comments
Open

ngTagInput #9

anrepppp opened this issue Nov 29, 2016 · 4 comments

Comments

@anrepppp
Copy link

anrepppp commented Nov 29, 2016

Ross,

You did a great job putting out the plugin. Actually i am referring to the Angular1 plugin ngTagInput and I see that following features are missing, can you please conform that are there any plans to extend this plugin to support more features like:

  • template: URL or id of a custom template for rendering each tag.
  • display-property: property to be rendered as the tag label,when returning from session we actually
    return string we convert and show it in the label.
  • key-property: Propertry to be used as a unique identifier for the tag.
  • text: Assignable Angular expression for data-binding to the element's text.
  • tabindex
  • allowLeftoverText: Sets leftoverText validation error key if there is any leftover text in the input
    element when the directive loses focus.
  • replaceSpacesWithDashes: Flag indicating that spaces will be replaced with dashes.
  • add-from-autocomplete-only = true.
  •                Flag indicating that only tags coming from the autocomplete list will be allowed. 
                   When the flag is true,addOnEnter, addOnComma, addOnSpace and addOnBlur 
                   values are ignored.
    
  • spellcheck = false.
  •           Flag indicating whether the browser's spellcheck is enabled for the input field or not.
    
  • onTagAdding: Expression to evaluate that will be invoked before adding a new tag.
    Tag will be added if the value is true or success promise.
  • onTagAdded: Expression to evaluate upon adding a new tag. This will call the refinment service and stores the response in search text.
  • onTagRemoved: Expression to evaluate upon removing an existing tag.(used for scrollTagInput).
@rosslavery
Copy link
Owner

Hey,

These are great suggestions. Some of these I've been planning on implementing for a while, but I don't have a lot of free time right now to do extensive updates. I typically do updates when one of our internal applications needs a feature. Right now we are in need of custom templates so it's something I'd like to get to shortly, but can't guarantee.

With regards to your add-from-autocomplete-only suggestion, there is already an option called autocompleteMustMatch, does this not accomplish what you're looking for?

Obviously PR's are greatly appreciated but not expected by any means.

@anrepppp
Copy link
Author

Ross, thanks for taking your time for replying me back. I am sorry, actually addFromAutocompleteOnly is similar to autocompleteMustMatch. It is there i agree.

@SteveDowsett
Copy link

Great plugin! Although it would be great if the tags could be key/value pairs so that the display could be a string and the data stored in the array could be the id. Its a real blocker for me as id love to be able to use this but i need to be able to work with the Id so that i can send the data back to an API call. Is this something that could be implemented soon? or i could do my self with a point in the right direction? Thanks again for all your work this far

@anrepppp
Copy link
Author

anrepppp commented Dec 12, 2016

Hey Ross,

I am quite wondering are you going to add a template property for autosuggestion as well. If i understand clearly from our last conversation you might be adding a template property for rl-taginput, but do you have any ideas to add template for autosuggestion specific. Because, in our project we kind of need two separate templates one for regular tags input and another for autosuggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants