Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add a "Mounted" section to the Files left pane ? #6

Open
TtuxX opened this issue Nov 10, 2022 · 7 comments
Open

[UI] Add a "Mounted" section to the Files left pane ? #6

TtuxX opened this issue Nov 10, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@TtuxX
Copy link

TtuxX commented Nov 10, 2022

What do you think of having a section related to mounted archives in the NC Files left pane ? (replacing the star and folders icons with your app's folder icon that has a link inside it)

This way, the user would have a similar experience to the one he has when mounting an .iso on his desktop.

The whole section would be foldable (with the little arrow on mouse hover), just like the Favorites and Shares entries.

image

Thank you very much.

@rotdrop rotdrop added the enhancement New feature or request label Nov 10, 2022
@rotdrop
Copy link
Owner

rotdrop commented Nov 10, 2022

Nice idea.

@rotdrop
Copy link
Owner

rotdrop commented Nov 15, 2022

Actually, after having a look at the comparable files_external view, the look would not be that fancy. Even for the files-sharing app the menu entries on the left are just categories, but not the actual shares. The folders are displayed in the main window.

That would be comparatively easy to achieve. The principal difficulty would be to invent names for the folders ;)

@rotdrop
Copy link
Owner

rotdrop commented Nov 15, 2022

After a closer look this seems to be a bit of a nightmare. It involves copying over and changing the files

apps/files_external/js/app.js
apps/files_external/js/mountsfilelist.js
apps/files_external/js/statusmanager.js

and maybe even more. And the code is really a bit ancient ...

@TtuxX
Copy link
Author

TtuxX commented Nov 15, 2022

After a closer look this seems to be a bit of a nightmare. It involves copying over and changing the files

Arf I'm sorry :( Thanks a lot for looking into this problem and digging into it!

@rotdrop
Copy link
Owner

rotdrop commented Nov 17, 2022

I am keeping this open. There is a feature branch feature/left-side-bar-menu. We will see ...

@hampoelz
Copy link

hampoelz commented Jun 18, 2024

I would suggest not creating a separate menu entry for each mount, as the menu could quickly become cluttered with multiple mounts and/or with long archive names. Something like files_external currently does would be better: A single menu entry linked to a view that displays all mounts in a list.

It also seems that adding entries in the Files left pane in combination with custom views has been simplified a lot in recent versions?

@rotdrop
Copy link
Owner

rotdrop commented Jun 21, 2024

I would suggest not creating a separate menu entry for each mount, as the menu could quickly become cluttered with multiple mounts and/or with long archive names. Something like files_external currently does would be better: A single menu entry linked to a view that displays all mounts in a list.

It also seems that adding entries in the Files left pane in combination with custom views has been simplified a lot in recent versions?

* https://nextcloud-libraries.github.io/nextcloud-files/classes/Navigation.html#register

* https://github.com/nextcloud/server/blob/master/apps/files_external/src/init.ts

Looks simple enough. I'll eventually have a look at files_external and how they do it. It should be possible to more or less just copy the code as the goal would be to give an overview over a collection of mount-points which is just what files_external does here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants