Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support inside/outside strokes #204

Open
dwelle opened this issue May 8, 2022 · 0 comments
Open

support inside/outside strokes #204

dwelle opened this issue May 8, 2022 · 0 comments

Comments

@dwelle
Copy link

dwelle commented May 8, 2022

Currently, strokes are centered in relation to the shape's outline, which results in two problems:

  1. if the stroke has non-100% opacity, the stroke is visibly different when it covers a filled shape
  2. when you want to create two elements, one with just a stroke and one with just a fill, they will be of different size (visually)

Figma gives you an option whether to make the stroke be inside, outside, or center:

image

Does it make sense for roughjs to support this as well?

Thinking about it, I would agree that for non-0 roughness (and 100% opacity), center stroke makes the most sense. For 0 roughness, inside is best, I think (which is why Figma and Miro defaults to it?).

Originally reported in excalidraw/excalidraw#5084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant