Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding "Keep formatting" in "dont_override" config #9704

Closed
wants to merge 11 commits into from

Conversation

JE4GLE
Copy link
Contributor

@JE4GLE JE4GLE commented Nov 15, 2024

Fixes #9703
According to this blog entry, "Keep formatting" is for power users and therefore it would be nice to be removable.

@pabzm
Copy link
Member

pabzm commented Nov 18, 2024

Thank you for the PR! Please rebase onto the latest state of the "master" branch and remove the translation-related commits.

@JE4GLE
Copy link
Contributor Author

JE4GLE commented Nov 18, 2024

@pabzm

Thank you for the PR! Please rebase onto the latest state of the "master" branch and remove the translation-related commits.

I rebased to the latest commit. I'm unsure on how to remove commits from the history. I already undid them and they are not part of the change. Do you want me to close this PR, create a new branch with a new PR?

@alecpl
Copy link
Member

alecpl commented Nov 19, 2024

This is incomplete. Well, maybe a rare case, but what if you set keep_formatting=true, and then add it to dont_override? A small change in rcmail_action_mail_send::run() is needed to support this case.

@JE4GLE
Copy link
Contributor Author

JE4GLE commented Nov 19, 2024

@alecpl

This is incomplete. Well, maybe a rare case, but what if you set keep_formatting=true, and then add it to dont_override? A small change in rcmail_action_mail_send::run() is needed to support this case.

Thank you, I changed it :)

program/actions/mail/send.php Outdated Show resolved Hide resolved
Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JE4GLE We need a line in the Changelog, would you maybe add one?

@pabzm
Copy link
Member

pabzm commented Nov 20, 2024

To be merged on 2024-12-04 unless someone comments.

program/actions/mail/send.php Outdated Show resolved Hide resolved
@pabzm pabzm self-requested a review November 20, 2024 11:21
Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to mention the actual config mechanism in the Changelog

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Pablo Zmdl <[email protected]>
Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! 👍

@pabzm
Copy link
Member

pabzm commented Nov 20, 2024

/remind me to merge on 2024-12-04

Copy link

@pabzm set a reminder for 12/4/2024

Copy link

github-actions bot commented Dec 4, 2024

👋 @pabzm, merge

@github-actions github-actions bot removed the reminder label Dec 4, 2024
@Promatur Promatur closed this by deleting the head repository Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hiding "Keep formatting" in "dont_override" config
5 participants