-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hiding "Keep formatting" in "dont_override" config #9704
Conversation
Thank you for the PR! Please rebase onto the latest state of the "master" branch and remove the translation-related commits. |
I rebased to the latest commit. I'm unsure on how to remove commits from the history. I already undid them and they are not part of the change. Do you want me to close this PR, create a new branch with a new PR? |
This is incomplete. Well, maybe a rare case, but what if you set |
Thank you, I changed it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@JE4GLE We need a line in the Changelog, would you maybe add one?
To be merged on 2024-12-04 unless someone comments. |
Co-authored-by: Carsten Brandt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to mention the actual config mechanism in the Changelog
Co-authored-by: Pablo Zmdl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! 👍
/remind me to merge on 2024-12-04 |
@pabzm set a reminder for 12/4/2024 |
👋 @pabzm, merge |
Fixes #9703
According to this blog entry, "Keep formatting" is for power users and therefore it would be nice to be removable.