Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AsyncRead and AsyncWrite from futures #3

Open
geigerzaehler opened this issue Jun 29, 2020 · 1 comment
Open

Implement AsyncRead and AsyncWrite from futures #3

geigerzaehler opened this issue Jun 29, 2020 · 1 comment

Comments

@geigerzaehler
Copy link
Contributor

It would be great if this crate would be compatible with futures and provide implementation of futures::io::AsyncWrite and futures::io::AsyncRead. This could potentially be feature gated.

I’d be happy to create a PR

@rousan
Copy link
Member

rousan commented Jun 29, 2020

Can you send a PR containing two features: "tokio" and "futures" to switch between them?

The user will use as follows:

To use futures crate:

async-pipe = { version = "0.1", features = ["futures"] }

To use tokio crate:

async-pipe = { version = "0.1", features = ["tokio"] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants