Compatibility with echodoc

[sassanh]

Currently ncm doesn't work with https://github.com/Shougo/echodoc.vim
I guess it's because the v:completed_item is not set properly so that echodoc can use it. Is it possible to make it compatible with echodoc?

[jsfaint]

echodoc.vim works with ncm on my side.
With this map (behavior like deoplete)

inoremap <expr><CR> (pumvisible()?(empty(v:completed_item)?"\<C-n>\<C-y>":"\<C-y>"):"\<CR>")

[sassanh]

Yeah, it's working now for me too. I close this issue.

[wwwdata]

Hm, got the same problem here as well. It works flawlessly for completion in go files but not within javascript files with the tern and flow plugins. Anybody has echodoc working for that as well?

[sassanh]

it works for console.log() but it doesn't work for PropTypes.any() for example (From react prop-types).

[jsfaint]

echodoc fail to work with recently ncm on my side.
Does anyone meet the same issue?

[jsfaint]

echodoc.vim work with press <c-n> and <c-y> manually, but fail to work with the setting below in current version of ncm.

inoremap <expr><CR> (pumvisible()?(empty(v:completed_item)?"\<C-n>\<C-y>":"\<C-y>"):"\<CR>")

I use git bisect to track the issue
The setting still works in this commit 41bc1a2

But fail to work in this commit 6053343

[viniarck]

+1. Thanks!