Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail view broken? #20

Open
KJThaDon opened this issue Dec 13, 2020 · 3 comments
Open

Thumbnail view broken? #20

KJThaDon opened this issue Dec 13, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@KJThaDon
Copy link

Not sure what's going on but the thumbnail for Cold War seems to just have a loading icon forever. When clicking and going to the full link it shows fine in the browser

https://static-cdn.jtvnw.net/ttv-boxart/Call%20of%20Duty:%20Black%20Ops%20Cold%20War-288x384.jpg

error

Also, is there a way to keep the preview image attached when the stream ends too?

Thank you!

@roydejong
Copy link
Owner

Broken cover art

I've seen this happen as well, and I'm not entirely sure why.

It should be noted that external images are proxied through Discord servers (through https://images-ext-2.discordapp.net/external/ or something similar), which is most likely where things are breaking.

One possibility is that we're hitting some kind of rate limit or issue because of how often the live post gets edited, and the images are re-fetched, but frankly I don't have a solution right now.

Keeping the live embed

Issue with keeping the live preview is that it stops working sometime after the stream ends, the image gets replaced by an empty / gray image on Twitch's server, so that's why it's currently getting removed once a stream goes offline.

It'd be rather complicated because the bot would have to cache the image itself and/or make it available via a server somehow.

@GoudronViande24
Copy link

It is probably due to a bug on Discord's side, because the image is rendered with the image URL by the Discord server, and not by the bot. You should try to open Discord in another browser, or with a different account and see if it loads.

@roydejong
Copy link
Owner

roydejong commented Jan 3, 2021

It is probably due to a bug on Discord's side, because the image is rendered with the image URL by the Discord server, and not by the bot.

I think so too but regardless I'd like to see if we can fix this on the bot's end, as this is a relatively common issue.

@roydejong roydejong added the bug Something isn't working label Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants