Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for editing existing labels #26

Open
christinab12 opened this issue Apr 10, 2024 · 5 comments
Open

Support for editing existing labels #26

christinab12 opened this issue Apr 10, 2024 · 5 comments

Comments

@christinab12
Copy link

Hi there,

I'm just trying out your plugin and it very nicely works when no segmentations are available. I was wondering if there is any support (or further interest to implement this) for having the "SAM box" and "SAM points" layers operate on existing labels layers whenever a segmentation mask is already available and needs to be slightly corrected?

Thanks,
Christina

@JoOkuma
Copy link
Member

JoOkuma commented Apr 11, 2024

Hi @christinab12,

We don't support it out of the box.
This could be accomplished by copying the object into want to correct into SAM mask layer.
Because SAM processes one object at a time, you must do this for every object you want to correct.

We could add a complementary widget to map a labels layer and a label value into the SAM mask.
Do you think this would be helpful?

Best,

@christinab12
Copy link
Author

Hi @JoOkuma,

thanks for your answer and sorry for the late reply. Re. the widget you suggested, would the mapping still need to be done on a per object basis?

@JoOkuma
Copy link
Member

JoOkuma commented May 3, 2024

Yes, @christinab12, I don't see an easy way to get around that because SAM expects a single segmentation instance

@christinab12
Copy link
Author

Thanks for your answer @JoOkuma,

I think this would probably still be a bottleneck for the user, so I think it's best to drop this for now. Feel free to close the issue!

@JoOkuma
Copy link
Member

JoOkuma commented May 8, 2024

Thanks for the update, @christinab12. I'll leave it open in case it's helpful to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants