Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_git_head_revision does not work on submodule #81

Open
diggit opened this issue Mar 6, 2024 · 2 comments
Open

get_git_head_revision does not work on submodule #81

diggit opened this issue Mar 6, 2024 · 2 comments

Comments

@diggit
Copy link

diggit commented Mar 6, 2024

Here variable ${GIT_EXECUTABLE} is used, but find_package(Git QUIET) is not called beforehand, thus it's empty resulting in empty ${out} and so on.

@rpavlik
Copy link
Owner

rpavlik commented Mar 7, 2024

Can you just add find_package(Git QUIET) in your CMake scripts? For some reason I assumed that was already required.

@diggit
Copy link
Author

diggit commented Mar 11, 2024

That is probably also an option, but for example git_describe, git_describe_working_tree, git_local_changes,.. handle this by themselves. Thus it's a bit non systematic to auto find git in some function a not in others. IMO this should be unified - none or all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants