Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in shortcode section #5

Open
jmcdl opened this issue Apr 26, 2020 · 0 comments
Open

Error in shortcode section #5

jmcdl opened this issue Apr 26, 2020 · 0 comments

Comments

@jmcdl
Copy link

jmcdl commented Apr 26, 2020

Thanks for this guide. I've found it really useful. I came across a couple of small errors in the shortcodes section.

  1. The updated src/index.njk example text is missing a quotation mark in the footer include
{% include "_foot.njk %}
  1. The suggested addShortCode function is also missing a closing quotation mark and has some superfluous angle brackets>
eleventyConfig.addShortcode("shorttest", function(subtitle, greeting){
    return "<h2><em>"+subtitle+"></em>, "+greeting+"></h2>
});

I would imagine it would be better to use a template literal as in the 11ty guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant