Use shutil.move instead of os.rename

[tewarid]

os.rename is unable to handle rename across file systems, or renames across read-only Docker overlayfs layers. The following statement may fail with error EXDEV (18).

createrepo/createrepo/__init__.py

Line 1406 in 73afabb

os.rename(output_final_dir, output_old_dir)

shutil.move is able to handle renames across file systems and Docker overlayfs layers.

[james-antill]

Did this come up in some automated/CI testing analysis?

The line, and function, you are referring to renames the name of a directory within another directory. For overlayfs you almost certainly want to shutil.rmtree the old directory instead of shutil.move'ing it. Probably need to add an option for that though, or do the rmtree aftger catching the exception.

[tewarid]

Did this come up in some automated/CI testing analysis?

I came across this while analyzing a similar issue in createrepo_c that is used by Yocto Project/OpenEmbedded.

The line, and function, you are referring to renames the name of a directory within another directory. For overlayfs you almost certainly want to shutil.rmtree the old directory instead of shutil.move'ing it. Probably need to add an option for that though, or do the rmtree aftger catching the exception.

I've found that shutil.move does a recursive copy and then removes the source directory, but shutil.rmtree may be worth providing as an alternative for performance reasons.