Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set build number for --test #332

Open
alexandrevicenzi opened this issue Feb 4, 2019 · 0 comments · May be fixed by #394
Open

Add option to set build number for --test #332

alexandrevicenzi opened this issue Feb 4, 2019 · 0 comments · May be fixed by #394
Labels
effort/medium Can be done in 1-2 days gain/high Significantly moves the project forward RFE This issue is a Request For Enhancement (Feature)

Comments

@alexandrevicenzi
Copy link

When using --test option the package name will be something like:

<package name>-<package version>.git.<commit count>.<last commit hash>.el7eng.noarch.rpm

foobar-0.0.1-1.git.0.5a86da9.el7eng.noarch.rpm

The problem is that sometimes the commit count is the same when building multiple patches. The count is usually 0 (zero) and the hash is not a number, in this case the new version string can be lower than the old one and the test package won't install because is a downgrade.

It would be nice to have an option to set this parameter. For example, when using Jenkins or other CI this parameter could easily be set to the BUILD NUMBER, this will ensure that the version is always greater than the older one.

I'm not sure if this option fits somewhere, maybe in the tito.props file or somewhere else.

So far I wrote a custom builder to do this trick and use CI build number.

@FrostyX FrostyX added the RFE This issue is a Request For Enhancement (Feature) label Mar 25, 2020
@abdullahzen abdullahzen linked a pull request Dec 26, 2020 that will close this issue
@FrostyX FrostyX added effort/medium Can be done in 1-2 days gain/high Significantly moves the project forward labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Can be done in 1-2 days gain/high Significantly moves the project forward RFE This issue is a Request For Enhancement (Feature)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants