Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line numbers are incorrect for templates #386

Open
rrd108 opened this issue Oct 7, 2024 · 6 comments
Open

line numbers are incorrect for templates #386

rrd108 opened this issue Oct 7, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@rrd108
Copy link
Owner

rrd108 commented Oct 7, 2024

As the template rules get only the template from the file the line numbers missing the script lines count.

If the code does not follow the script -> template -> style order, then the same happens to the 2nd and 3rd block

@rrd108 rrd108 added the bug Something isn't working label Oct 7, 2024
@David-Pena
Copy link
Collaborator

If the code does not follow the script -> template -> style order, then the same happens to the 2nd and 3rd block

@rrd108 Should we always receive the entire SFCDescriptor? It would have an effect in perf because now would be checking a bigger chunk of component/file every time 👀🤔

@rrd108
Copy link
Owner Author

rrd108 commented Oct 12, 2024

I was thinking about this but I do not think it will have any viewable effect on performancs.

Or do you have some other worry?

@David-Pena
Copy link
Collaborator

Or do you have some other worry?

Nope, just that

@David-Pena David-Pena self-assigned this Oct 22, 2024
@David-Pena
Copy link
Collaborator

I'll take care of this one 🫡

@David-Pena
Copy link
Collaborator

Do we have some examples for this? I'm not sure with which rule to start 🤔 @rrd108

@rrd108
Copy link
Owner Author

rrd108 commented Nov 5, 2024

Any rule what checks the template. Like v-for expressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants