Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple comparison correction in plot_model_comparison #398

Open
JasperVanDenBosch opened this issue Jun 25, 2024 · 2 comments
Open

Multiple comparison correction in plot_model_comparison #398

JasperVanDenBosch opened this issue Jun 25, 2024 · 2 comments

Comments

@JasperVanDenBosch
Copy link
Contributor

Currently all the MCC happens in the visualization code and not on the Result object. Maybe we could do this on the Result object / consolidate the code. The default options should probably be similar to avoid confusion as to differences between the plot and the Result object

@jdiedrichsen
Copy link
Contributor

As argued - my strong preference for transparancy is to internally store and use uncorrected p-values.
For plots and high-level inference routines, MCC should be an option that can be switched on.

Automatic MCC is confusing and doesn't make sense from a scientific standpoint.

Joern

@JasperVanDenBosch
Copy link
Contributor Author

Agreed - the default could be False for both - as long as they share the same default behavior or at least make the behavior obvious to prevent this kind of confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants