Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide an ability to exclude files/directories from bundles #571

Open
r2evans opened this issue Aug 5, 2019 · 2 comments
Open

provide an ability to exclude files/directories from bundles #571

r2evans opened this issue Aug 5, 2019 · 2 comments

Comments

@r2evans
Copy link

r2evans commented Aug 5, 2019

Other than specifically src, lib, bundles, and vcs.history, it would be very useful to omit specific files or sub-directories from a bundle.

My first thought was to include extra_flags="--exclude data-raw", but since bundle forces the use of the internal tar (vice the tar executable), the extra_flags= argument is ignored.

Some options:

  • Allow the user to override tar=. There are incompatibilities between internal and command-line tar, so this might not be possible, but it would allow the use of extra_flags= if done correctly.

  • Add bundle(..., exclude=) where exclude is either a vector of files/dirs to remove completely or patterns to match against all files. This would require changing from files=basename(project) to an actual vector of files/dirs to include, appropriately filtered.

@r2evans
Copy link
Author

r2evans commented Aug 5, 2019

Also, would allowing pattern-exclusion help with the current method of copying all files into a new directory? That seems unnecessary (and inefficient, esp for large projects) if you can control the files passed to tar.

@alexiswl
Copy link

This would be fantastic!
My very ugly workaround is chmod u-rwx data; bundle_command.sh; chmod u+rwx data;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants