We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait_for_value()
ignore
identical()
In this line, wait_for_value() is using identical() to compare the ignore parameter with the result of $get_value()
$get_value()
shinytest2/R/app-driver-wait.R
Line 133 in 799b11c
This can lead to a situation where wait_for_value() doesn't actually wait if ignore = 1 and value = 1L (i.e., value is an integer but ignore isn't).
ignore = 1
value = 1L
value
It seems better if the comparison was less strict, perhaps using all.equal() (similar to the difference between expect_identical() and expect_equal())
all.equal()
expect_identical()
expect_equal()
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In this line,
wait_for_value()
is usingidentical()
to compare theignore
parameter with the result of$get_value()
shinytest2/R/app-driver-wait.R
Line 133 in 799b11c
This can lead to a situation where
wait_for_value()
doesn't actually wait ifignore = 1
andvalue = 1L
(i.e.,value
is an integer butignore
isn't).It seems better if the comparison was less strict, perhaps using
all.equal()
(similar to the difference betweenexpect_identical()
andexpect_equal()
)The text was updated successfully, but these errors were encountered: