You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because of a weird situation with an unusual legacy UI framework in our Elm code, I noticed that elm-css will emit an empty style node if there are no classes. Generally that's not an issue, but inside a large table where each cell contains some rendered Html.Styled, it noticeably affects the performance of the page.
This is a problem with our code more than elm-css, but it's worth potentially improving the library as well. What do you think of not emitting the style node if the list of styles for a given node is empty? (For instance here and equivalent methods.)
Happy to put up a PR if this seems reasonable.
The text was updated successfully, but these errors were encountered:
Because of a weird situation with an unusual legacy UI framework in our Elm code, I noticed that
elm-css
will emit an empty style node if there are no classes. Generally that's not an issue, but inside a large table where each cell contains some renderedHtml.Styled
, it noticeably affects the performance of the page.This is a problem with our code more than
elm-css
, but it's worth potentially improving the library as well. What do you think of not emitting thestyle
node if the list of styles for a given node is empty? (For instance here and equivalent methods.)Happy to put up a PR if this seems reasonable.
The text was updated successfully, but these errors were encountered: