Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken for ES5 since 2.3.6 #173

Open
Jesus89 opened this issue Jul 22, 2017 · 4 comments
Open

Broken for ES5 since 2.3.6 #173

Jesus89 opened this issue Jul 22, 2017 · 4 comments

Comments

@Jesus89
Copy link

Jesus89 commented Jul 22, 2017

Pull request #171 adds ES6 code, crashing for ES5 projects.

@rubenv
Copy link
Owner

rubenv commented Jul 24, 2017

@Jesus89 This is angular-gettext-tools, which you normally only call from Node.

What do you mean with ES5 projects?

@Jesus89
Copy link
Author

Jesus89 commented Jul 27, 2017

Hi @rubenv

I am using angular-gettext-tools in a NW.js project without babel. All is written in EcmaScript5. When I updated the dependencies, the following error appeared:

".../node_modules/typescript-eslint-parser/lib/ast-converter.js:41
module.exports = (ast, extra) => {
                              ^^
Unexpected token =>"

So I checked that from 2.3.5 to 2.3.6, two major jumps where added in the 'typescript-eslint-parser' package, than includes EcmaScript6 code. I didn't expect that in a bugfix release, so I changed from "~2.3.3" to "2.3.5".

@rubenv
Copy link
Owner

rubenv commented Jul 27, 2017

I see, didn't expect them to make that much of a jump either.

Either way: I'm pretty sure NW.js supports short function syntax, have you tried upgrading your runtime?

@Jesus89
Copy link
Author

Jesus89 commented Jul 27, 2017

I have pending to update NW.js to the latest version in my project. I will check this issue again when all is up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants