Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant blocks for factory and association #81

Open
ydakuka opened this issue Oct 20, 2023 · 0 comments
Open

Redundant blocks for factory and association #81

ydakuka opened this issue Oct 20, 2023 · 0 comments
Labels

Comments

@ydakuka
Copy link

ydakuka commented Oct 20, 2023

# bad
FactoryBot.define do
  factory :user do
    publisher factory: %i[publisher]
    advertiser { association(:advertiser) }
  end
end

# good
FactoryBot.define do
  factory :user do
    publisher
    advertiser
  end
end
@ydah ydah added the cop label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants