Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rufo breaks =begin =end comment block in erb file #310

Open
ironsand opened this issue Aug 13, 2023 · 1 comment
Open

rufo breaks =begin =end comment block in erb file #310

ironsand opened this issue Aug 13, 2023 · 1 comment

Comments

@ironsand
Copy link

When using this kind of comment block, =begin and =end must be at start of the lines.

<%
=begin

This is a comment.

=end
%>

But rufo moves the positions and it seems to break the code.

<% =begin
  
  This is a comment.
  
  =end %>

I simply removed the comment from the template file to fix the issue.
Is it better to avoid using this type of comment?

rufo -v
rufo 0.16.2
@kzkn
Copy link
Member

kzkn commented Sep 3, 2023

Thanks for the report.
Breaking valid application codes can be called as a bug of rufo.
But rufo doesn't support the style currently. So I think your workaround is simple and good.

Welcome pullreq for the bugfix 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants