Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grape 2.2.0 is incompatible with grape-rabl #53

Open
znz opened this issue Sep 17, 2024 · 1 comment
Open

grape 2.2.0 is incompatible with grape-rabl #53

znz opened this issue Sep 17, 2024 · 1 comment
Labels

Comments

@znz
Copy link

znz commented Sep 17, 2024

grape-rabl 0.5.0 uses Grape::Formatter.formatter_for with one argument.

def fallback_formatter
Grape::Formatter.formatter_for(env[Grape::Env::API_FORMAT])

But grape 2.2.0 changed its arity.

ruby-grape/grape@v2.1.3...v2.2.0#diff-2332fb7b55e286e39346d06d8427673ae0dade2d41786327b23375cc30ef2ffaR17

So wrong number of arguments (given 1, expected 2) raised.

In our application, following monkey patch resolved the exception.

module Grape
  module Formatter
    module_function

    def formatter_for(api_format, formatters=nil)
      select_formatter(formatters, api_format) || DEFAULT_LAMBDA_FORMATTER
    end
  end
end
@dblock dblock transferred this issue from ruby-grape/grape Sep 17, 2024
@dblock
Copy link
Member

dblock commented Sep 17, 2024

I am moving this to grape-rabl since it's really a problem with the latter.

Want to try and fix this here? Maybe start with #52.

@dblock dblock added the bug label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants