Skip to content
This repository has been archived by the owner on Oct 19, 2018. It is now read-only.

changing data base from console regression #21

Open
catmando opened this issue May 2, 2018 · 3 comments
Open

changing data base from console regression #21

catmando opened this issue May 2, 2018 · 3 comments

Comments

@catmando
Copy link
Contributor

catmando commented May 2, 2018

This commit 28ef6e6#diff-e50e457d8517d82c3828c357d305a74e seems to have caused a regression.

revert back to simple on_server? returning !Rails.const_defined?('Console')

In debugging this it seem there is some old unreachable code in connection#needs_initialization.

@janbiedermann
Copy link
Contributor

reverting will probably lead to a performance regression for Puma

@janbiedermann
Copy link
Contributor

i suggest the following:
@on_server ||= (ARGV & %w[c console]).size == 0

@catmando
Copy link
Contributor Author

catmando commented May 4, 2018

i think I got it...

catmando added a commit that referenced this issue May 5, 2018
catmando added a commit that referenced this issue May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants