Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AlgoCollector] Improve weekly problems comment picking #1459

Open
ledongthuc opened this issue Aug 8, 2021 · 0 comments
Open

[AlgoCollector] Improve weekly problems comment picking #1459

ledongthuc opened this issue Aug 8, 2021 · 0 comments

Comments

@ledongthuc
Copy link
Collaborator

ledongthuc commented Aug 8, 2021

Source code: https://github.com/ruby-vietnam/hardcore-rule/tree/master/algorithms/collector

Background

  • Algorithm collector access Algorithm weekly report page to get "Weekly problems". It always expects the latest comment on the page as the latest problems of the current week.

Problems

  • Sometimes, we have to discuss or add comments on Algorithm weekly report page that makes the latest comment on the page is not the latest problems comment.

Proposal

  • When checking comments of Algorithm weekly report page, we check starting pattern "Weekly problem:" as first problems posts and assume it's problem's comments.
  • Algorithm collector use the latest comment that starts with "Weekly problem:" and expect it as the latest problems comment. Other comments without starting of "Weekly problem:", we skip it.
  • Trim space/tab to avoid typing problems.
  • Allows custom starting problem patterns from the variable environments. Default is "Weekly problem:"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant