Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public key operations support with the EVP API #370

Closed
4 tasks done
rhenium opened this issue May 18, 2020 · 1 comment
Closed
4 tasks done

Public key operations support with the EVP API #370

rhenium opened this issue May 18, 2020 · 1 comment
Milestone

Comments

@rhenium
Copy link
Member

rhenium commented May 18, 2020

We currently provide wrappers for the public key cryptographic functions in each OpenSSL::PKey subclass. They have to be rewritten sooner or later to migrate to the EVP API from the low-level API, which is legacy and being deprecated by OpenSSL (#369).

Also, they don't have consistent method naming and signatures across those classes. It sounds like it's a good time to reorganize.

  • OpenSSL::PKey::RSA#private_encrypt and #public_decrypt
    • → OpenSSL::PKey::PKey#{sign,verify}_raw
  • OpenSSL::PKey::DSA#syssign and #sysverify
    • → OpenSSL::PKey::PKey#{sign,verify}_raw
  • OpenSSL::PKey::EC#dsa_sign_asn1 and #dsa_verify_asn1
    • → OpenSSL::PKey::PKey#{sign,verify}_raw
  • OpenSSL::PKey::RSA#public_encrypt and #private_decrypt
    • → OpenSSL::PKey::PKey#{encrypt,decrypt}
  • OpenSSL::PKey::DH#compute_key
    • → OpenSSL::PKey::PKey#derive
  • OpenSSL::PKey::EC#dh_compute_key
    • → OpenSSL::PKey::PKey#derive

Wrappers should be implemented within OpenSSL::PKey for:

@rhenium
Copy link
Member Author

rhenium commented Sep 27, 2021

This is now implemented in #329 and #382.

@rhenium rhenium closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant