Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spec for CLI option "-W:no-deprecated" introduced in Ruby 2.7 #803

Merged

Conversation

lxxxvi
Copy link
Contributor

@lxxxvi lxxxvi commented Oct 21, 2020

Hello 👋

Here's my suggestion to cover this one from #745

The -W option has been extended with a following :, to manage categorized
warnings. Feature #16345 Feature #16420

I always find it tricky to assert for nothing (empty string), that's why I also added an assertion for the deprecation warning if option -W:no-deprecated is not given. Do you think this makes sense?

Looking forward to receiving your feedback.

@eregon
Copy link
Member

eregon commented Oct 21, 2020

Thanks, this looks good.
I'm not sure there is a good way to emit a deprecation warning no matter the Ruby version running the test.

@eregon eregon merged commit 28ff1f9 into ruby:master Oct 21, 2020
@andrykonchin
Copy link
Member

TBH I am wondering how '2>&1' works on Windows. AFAIK we run specs on CI on Windows as well.

@eregon
Copy link
Member

eregon commented Oct 21, 2020

I think whatever shell is used by Ruby on Windows supports it. @MSP-Greg probably knows better.

@MSP-Greg
Copy link
Contributor

2>&1 works in PowerShell. I use it building ruby-loco.

@lxxxvi lxxxvi deleted the add-spec-for-cli-dash_upper_w-no-deprecated branch October 22, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants