Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds IO#set_encoding_by_bom spec #813

Merged
merged 2 commits into from
Nov 3, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions core/io/set_encoding_by_bom_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
require_relative '../../spec_helper'

describe "IO#set_encoding_by_bom" do
before :each do
@name = tmp('io_set_encoding_by_bom.txt')
touch(@name)
@io = new_io(@name, 'rb')
end

after :each do
@io.close unless @io.closed?
rm_r @name
end

ruby_version_is "2.7" do
it "returns the result encoding if found BOM UTF-8 sequence" do
File.write(@name, "\u{FEFF}abc")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File.binwrite seems better here


@io.set_encoding_by_bom.should == Encoding::UTF_8
@io.external_encoding.should == Encoding::UTF_8
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add examples for UTF-16LE and UTF16-BE BOM?


it "returns nil if found BOM sequence not provided" do
File.write(@name, "abc")

@io.set_encoding_by_bom.should == nil
end

it 'returns exception if io not in binary mode' do
not_binary_io = new_io(@name, 'r')

-> { not_binary_io.set_encoding_by_bom }.should raise_error(ArgumentError, 'ASCII incompatible encoding needs binmode')
not_binary_io.close
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this in a begin/ensure/end? So even if the assertion fails, the IO is still closed.

end

it 'returns exception if encoding already set' do
@io.set_encoding("utf-8")

-> { @io.set_encoding_by_bom }.should raise_error(ArgumentError, 'encoding is set to UTF-8 already')
end
end
end