Add specs to cover the fix for [Bug #14266]

[wenderjean]

Covering "Set#clone(freeze: false) makes frozen internal hash" from #823

Kernel#clone when called with the freeze: false keyword will call
#initialize_clone with the freeze: false keyword.
[Bug #14266]

[eregon]

Thank you for the contribution.
The spec should also include the behavior change though, not only the specific bug with Set (which is still useful to test though).

I think it should be a spec of Kernel#clone, in core/kernel/clone_spec.rb, and should test that initialize_clone(freeze: false) is called by clone(freeze: false).

[wenderjean]

@eregon I wonder if we should remove that library/set/clone_spec.rb and validate the behavior only in core/kernel/clone_spec.rb as you suggested? One other question, when you say should test that initialize_clone(freeze: false) is called by clone(freeze: false), I should do it by using kind of a spy (ensure it was called once with) or just testing that the new copy is not frozen as I did with the current expectation?

[eregon]

@eregon I wonder if we should remove that library/set/clone_spec.rb and validate the behavior only in core/kernel/clone_spec.rb as you suggested?

Might be better since there is no Set#clone method.
We could still test the specific case of Set in core/kernel/clone_spec.rb to ensure that works as it was found to be potentially problematic.

One other question, when you say should test that initialize_clone(freeze: false) is called by clone(freeze: false), I should do it by using kind of a spy (ensure it was called once with) or just testing that the new copy is not frozen as I did with the current expectation?

A kind of spy, you can use obj.should_receive(method).with(args), see the existing specs doing that.

[eregon]

@wenderjean Could you add specs in core/kernel/clone_spec.rb as discussed above?

[wenderjean]

@eregon Sure, I didn't push my changes yet because I'm struggling to configure a spy to ensure initialize_clone is called, the other examples in the repository are different from what I need. I'll push what I have so far.

[eregon]

Thanks, I ended using a fixture class, see the diff.