Add spec confirming Runtime error when a class variable is overtaken #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 27, 2021
| it "raises Runtime error when a defined class variable is overtaken" do | ||
| -> do | ||
| eval <<-CODE | ||
| @@cvar_a = :new_val |
There was a problem hiding this comment.
This checks accessing a class variable from the toplevel (i.e., not under some class/module), but not overtaking itself, which is something different: setting a class var in a parent class when it's already defined in a child class.
Could you try to add a separate example (it) for that?
There was a problem hiding this comment.
👍, initially I was reading the description as "it should raise an error when the parent class tries to define the class variable already defined by the child".
Added the needed test.
- also update test definitions to better describe the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #823