Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS Scanner #137

Open
korny opened this issue Jun 11, 2013 · 6 comments · May be fixed by #162
Open

SCSS Scanner #137

korny opened this issue Jun 11, 2013 · 6 comments · May be fixed by #162
Labels
Milestone

Comments

@korny
Copy link
Member

korny commented Jun 11, 2013

Was: #93

@thybzi thybzi mentioned this issue Jul 26, 2013
@Piderman
Copy link

Piderman commented Feb 6, 2014

in regards to this #93 (comment) are you happy for others to attempt?

@korny
Copy link
Member Author

korny commented Feb 6, 2014

Of course! Please, go ahead.

@Piderman
Copy link

Piderman commented Feb 7, 2014

Awesome! I'll give it a go

@Piderman
Copy link

Piderman commented Feb 8, 2014

Getting there. Having some trouble with nested selectors, namely tags. Are you able to explain how the block works?

@korny
Copy link
Member Author

korny commented Feb 8, 2014

Not sure what you mean. The :block state determines whether you are inside a style definition or outside. Of course, SCSS is nested so you need to use the stack and find out where nested blocks start.

If you find it tricky to tell tags (like div) apart from style keys (like font-size), it might make sense to check for the presence of a colon (check(/\s*:/) or something).

You might also find patch #143 for the SASS scanner useful, I've had similar problems there and decided that it's better to check for colons than trying to keep track of the nesting level…

@Piderman
Copy link

Piderman commented Feb 9, 2014

Thanks for help. I had classes working but not elements. The above should solve the inconsistencies here with the li and min-width
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants