Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist for MFA requirement release #3163

Closed
6 of 7 tasks
jenshenny opened this issue Aug 2, 2022 · 2 comments
Closed
6 of 7 tasks

Checklist for MFA requirement release #3163

jenshenny opened this issue Aug 2, 2022 · 2 comments

Comments

@jenshenny
Copy link
Member

jenshenny commented Aug 2, 2022

This issue tracks what should be completed for MFA enforcement on Aug 15
RFC Phase 3

Required but should be merged before release

Deployed day of

Enhancements (not required for release)

@jenshenny
Copy link
Member Author

@bettymakes @jchestershopify @kevinlinxc and I tophatted these flows on staging. We couldn't modify data on staging so we were only able to test some cases. cases highlighted with an asterisk were tested only on local

User with more than 180 mil downloads

MFA disabled user

  • login to find MFA setup
    Confirmed the following routes redirected to MFA setup:
    /settings/edit
    /dashboard
    /gems/:rubygem_id/owners
    /profile/api_keys
    /profile/api_keys/new
    /notifier
    /sessions/verify
  • error for gem push
  • error for gem yank
  • error for gem add owner
  • error for gem remove owner
  • error for gem signin

MFA UI only user

  • login to find banner and redirect to settings, cannot navigate to authenticated pages
    Confirmed the following routes redirected to edit settings:
    /dashboard
    /gems/:rubygem_id/owners
    /profile/api_keys
    /profile/api_keys/new
    /notifier
    /sessions/verify
  • error for gem push*
  • error for gem yank*
  • error for gem add owner*
  • error for gem remove owner*
  • error for gem signin

MFA UI_and_gem_signin user

  • nothing in login
  • no error for gem push
  • no error for gem yank
  • no error for gem add owner
  • no error for gem remove owner
  • no error for gem signin

User with 165-180 mil downloads

MFA disabled user

  • login to find MFA setup, can navigate away*
  • warning for gem push*
  • warning for gem yank*
  • warning for gem add owner*
  • warning for gem remove owner*

MFA UI only user

  • login to find edit settings with warnings, can navigate away*
  • warning for gem push*
  • warning for gem yank*
  • warning for gem add owner*
  • warning for gem remove owner*

User with less than 165 mil downloads

MFA disabled user

  • nothing in login
  • no error or warnings for gem push
  • no error or warnings for gem yank
  • no error or warnings for gem add owner
  • no error or warnings for gem remove owner

MFA UI only user

  • nothing in login*
  • no error or warnings for gem push*
  • no error or warnings for gem yank*
  • no error or warnings for gem add owner*
  • no error or warnings for gem remove owner*

*unable to test on staging, tested on local machine

@bettymakes
Copy link
Contributor

✅ Everything is complete in the check list besides the enhancement feature, which was not required for the release. We should be good to close this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants