Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruckusing_Migration_Base::split_query doesn't work properly in escape #145

Open
Anye opened this issue Nov 19, 2014 · 3 comments
Open

Ruckusing_Migration_Base::split_query doesn't work properly in escape #145

Anye opened this issue Nov 19, 2014 · 3 comments

Comments

@Anye
Copy link

Anye commented Nov 19, 2014

When run $this->execute() the sql update xxxx set desc='xxxx    xxxxx', it can't work properly cuz Ruckusing_Migration_Base::split_query split that sql into three parts.

@ruckus
Copy link
Owner

ruckus commented Nov 19, 2014

Interesting. Yes I can see this being an issue since split_query is naive. We might have to implement an option to execute like array('split' => false) in those instances where you are sure you don't want any splitting to occur.

@silverslice
Copy link
Contributor

Anye, update your library's version. This bug was fixed in #123 issue

@ruckus ruckus closed this as completed Feb 20, 2015
@ruckus
Copy link
Owner

ruckus commented Mar 6, 2015

I'm wondering if this whole split-query support is causing more harm than good.

#154

@ruckus ruckus reopened this Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants