From 3c289886b852c24dbc155108ebcc1401c13f2ca3 Mon Sep 17 00:00:00 2001
From: AASHISH MALIK <imashishmalik.45@gmail.com>
Date: Tue, 27 Feb 2024 02:17:31 +0530
Subject: [PATCH] fix: convert to string from null in hs

---
 src/v0/destinations/hs/util.js                |  4 +-
 src/v0/util/index.js                          |  2 +
 .../destinations/hs/processor/data.ts         | 98 +++++++++++++++++++
 3 files changed, 103 insertions(+), 1 deletion(-)

diff --git a/src/v0/destinations/hs/util.js b/src/v0/destinations/hs/util.js
index 32ee923f5fc..8cbd63e9d8d 100644
--- a/src/v0/destinations/hs/util.js
+++ b/src/v0/destinations/hs/util.js
@@ -19,6 +19,7 @@ const {
   getHashFromArray,
   getDestinationExternalIDInfoForRetl,
   getValueFromMessage,
+  isNull,
 } = require('../../util');
 const {
   CONTACT_PROPERTY_MAP_ENDPOINT,
@@ -223,7 +224,8 @@ const getTransformedJSON = async (message, destination, propertyMap) => {
       // lowercase and replace ' ' & '.' with '_'
       const hsSupportedKey = formatKey(traitsKey);
       if (!rawPayload[traitsKey] && propertyMap[hsSupportedKey]) {
-        let propValue = traits[traitsKey];
+        // HS accepts empty string to remove the property from contact
+        let propValue = isNull(traits[traitsKey]) ? '' : traits[traitsKey];
         if (propertyMap[hsSupportedKey] === 'date') {
           propValue = getUTCMidnightTimeStampValue(propValue);
         }
diff --git a/src/v0/util/index.js b/src/v0/util/index.js
index 1d952693f27..97924012414 100644
--- a/src/v0/util/index.js
+++ b/src/v0/util/index.js
@@ -52,6 +52,7 @@ const removeUndefinedAndNullAndEmptyValues = (obj) =>
   lodash.pickBy(obj, isDefinedAndNotNullAndNotEmpty);
 const isBlank = (value) => lodash.isEmpty(lodash.toString(value));
 const flattenMap = (collection) => lodash.flatMap(collection, (x) => x);
+const isNull = (x) => lodash.isNull(x);
 // ========================================================================
 // GENERIC UTLITY
 // ========================================================================
@@ -2266,6 +2267,7 @@ module.exports = {
   isDefinedAndNotNullAndNotEmpty,
   isEmpty,
   isNotEmpty,
+  isNull,
   isEmptyObject,
   isHttpStatusRetryable,
   isHttpStatusSuccess,
diff --git a/test/integrations/destinations/hs/processor/data.ts b/test/integrations/destinations/hs/processor/data.ts
index 03ad9d0a3b3..0ab44e382ba 100644
--- a/test/integrations/destinations/hs/processor/data.ts
+++ b/test/integrations/destinations/hs/processor/data.ts
@@ -5269,4 +5269,102 @@ export const data = [
       },
     },
   },
+  {
+    name: 'hs',
+    description: 'Test coversion of null to string values',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            message: {
+              description:
+                '[HS] (newApi): get contact from hs with email (lookupField) having no contacts',
+              channel: 'web',
+              context: {
+                app: {
+                  build: '1.0.0',
+                  name: 'RudderLabs JavaScript SDK',
+                  namespace: 'com.rudderlabs.javascript',
+                  version: '1.0.0',
+                },
+                traits: {
+                  email: 'noname@email.com',
+                  firstname: null,
+                  gender: '',
+                  lookupField: 'email',
+                }
+              },
+              type: 'identify',
+              userId: '12345',
+              integrations: {
+                All: true,
+              }
+            },
+            destination: {
+              Config: {
+                authorizationType: 'newPrivateAppApi',
+                accessToken: 'dummy-access-token',
+                hubID: 'dummy-hubId',
+                apiKey: 'dummy-apikey',
+                apiVersion: 'newApi',
+                lookupField: 'email',
+                hubspotEvents: [],
+                eventFilteringOption: 'disable',
+                blacklistedEvents: [
+                  {
+                    eventName: '',
+                  },
+                ],
+                whitelistedEvents: [
+                  {
+                    eventName: '',
+                  },
+                ],
+              },
+              Enabled: true,
+            },
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            output: {
+              version: '1',
+              type: 'REST',
+              userId: '',
+              method: 'POST',
+              endpoint: 'https://api.hubapi.com/crm/v3/objects/contacts',
+              headers: {
+                'Content-Type': 'application/json',
+                Authorization: 'Bearer dummy-access-token',
+              },
+              params: {},
+              operation: 'createContacts',
+              body: {
+                JSON: {
+                  properties: {
+                    email: 'noname@email.com',
+                    firstname: '',
+                    gender: ''
+                  },
+                },
+                JSON_ARRAY: {},
+                XML: {},
+                FORM: {},
+              },
+              files: {},
+            },
+            statusCode: 200,
+          },
+        ],
+      },
+    },
+  },
 ];