Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSSION]: Replace panic from RocksDB #166

Open
NYBACHOK opened this issue Jul 12, 2024 · 0 comments
Open

[DISCUSSION]: Replace panic from RocksDB #166

NYBACHOK opened this issue Jul 12, 2024 · 0 comments

Comments

@NYBACHOK
Copy link
Collaborator

Original comment:

  fn get(&self, key: &[u8]) -> Option<Vec<u8>> {
        self.db
            .get(key)
            .unwrap_or_else(|e| panic!("unrecoverable database error {}", e)) //TODO: this is probably 
// not the right thing to do when handling a abci or REST query. Perhaps we should have a must_get method?
    }

We need to re-think is it correct to panic if no value found in db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant