Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of logs logged at info level #4916

Open
1 task done
lorenzofelletti opened this issue Sep 11, 2024 · 0 comments
Open
1 task done

Reduce amount of logs logged at info level #4916

lorenzofelletti opened this issue Sep 11, 2024 · 0 comments
Labels
feature New functionality/enhancement

Comments

@lorenzofelletti
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story
A running Atlantis instance with logging level set to info logs every few seconds information about the lock status, most of the times this being the lock is free. I find very little utility in logging that a project is unlocked that many times.

Describe the solution you'd like
My suggestion would be to inspect the lock status and only log to info level if the lock is taken, and logging to debug level otherwise, if not more drastically demote the lock status log to debug entirely.

Describe the drawbacks of your solution
Inspecting the lock status and then decide which log level to use for that information would make the code a bit more verbose, but I think it's worth saving thousands of lines of logs.

Describe alternatives you've considered

As I already said, an alternative would be to demote the log to debug entirely. This option would leave the code as readable as it it, but may hinder the visibility of taken locks through logs (I don't this this would be a big issue, but it's worth noting it).

@lorenzofelletti lorenzofelletti added the feature New functionality/enhancement label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant