Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-haspopup no-incompatible-type-binding false alarm #142

Open
pmcelhaney opened this issue Sep 30, 2020 · 3 comments · May be fixed by #175
Open

aria-haspopup no-incompatible-type-binding false alarm #142

pmcelhaney opened this issue Sep 30, 2020 · 3 comments · May be fixed by #175

Comments

@pmcelhaney
Copy link

The following code triggers Type '"listbox"' is not assignable to '"true" | "false"'lit-plugin(no-incompatible-type-binding)(2304).

<button aria-haspopup="listbox"></button>

That's not accurate. aria-haspopup can several values other than "true" or "false".

https://www.w3.org/TR/wai-aria/#aria-haspopup

I did a quick scan through the code and it looks like the bug may be in an upstream dependency. If someone can point me in the right direction I'll open a PR.
@bradniksa
Copy link

I second this issue, I am getting the same error.

Screen Shot 2021-03-26 at 9 59 18 AM

@joekukish joekukish linked a pull request Jun 9, 2021 that will close this issue
Open
@joekukish
Copy link

I've made a PR for this: #175

@brentswisher
Copy link

@rictic just a heads up I am pretty sure release v2.0.1 fixed this issue and it and #175 can both be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

aria-haspopup no-incompatible-type-binding false alarm joekukish/lit-analyzer
4 participants
@pmcelhaney @joekukish @bradniksa @brentswisher