Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Helm 3 #1

Open
batiati opened this issue Sep 20, 2020 · 6 comments
Open

[Question] Helm 3 #1

batiati opened this issue Sep 20, 2020 · 6 comments

Comments

@batiati
Copy link

batiati commented Sep 20, 2020

I saw the selector is set to OWNER=TILLER , can Helm 3 releases be bakckuped using this plugin or it isn't necessary anymore?
I mean, can I backup a Helm 3 release using just the velero's builtin --selector release=my-release?

@runzexia
Copy link
Owner

sorry this plugin current not support helm3, as https://github.com/runzexia/velero-plugin-helm/blob/master/pkg/plugin/backupplugin.go#L73.
However, I don't think it is difficult to add helm3 support. If you are interested, we can finish it together

@runzexia
Copy link
Owner

After doing some research, I found that it is difficult to dep on helm2 and helm3 through the go module at the same time in the master branch.
A better approach may be to divide into two branches, v2 and v3, and write plug-ins for helmv2 and helmv3 respectively.

@batiati
Copy link
Author

batiati commented Sep 21, 2020

Hi,

To be honest, I couldn't figure out what was left out of the backup when I just used --selector release=my-app without any plugin ... At first look it seems that even the helm's secrets were backuped correctly.

I haven't had enough time to dig into more complex scenarios and check the complete release's history, upgrades, rollbacks, etc.

(...)

I would be happy to help

@runzexia
Copy link
Owner

helm use configmap/secret to store release info.
if you run create backup with --selector release=my-app, velero would not know the workload to be backup.It is only know the secret and this helm plugin help this.
When create backup with helm storage(secret/configmap),this plugin would parse the content of helm storage, and tell velero what need to backup.
Generally, we need parse helm release with deployed status.
Another thing may need to think is helm hook

@runzexia
Copy link
Owner

i made this repo has two branch, v2 for helm2 and v3 for helm3.

@batiati
Copy link
Author

batiati commented Sep 22, 2020

I see!
I was restoring over an existing release, so the result was correct; But, if I delete the helm release prior to restore, velero has no way to know all helm's related resources.

I'm going to take a look on it.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants