WIP : Maintenance window resource #63
Conversation
Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault
changed the title
Signed-off-by: Nicolas Lamirault <[email protected]>
|
Any chance this can be merged soon-ish? Thank you. |
|
Please, pretty please! |
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
|
Looks like there has been activity. What remains to be done for this to be merged? Anything I can do that would be useful? |
| return fmt.Errorf("Error retrieving id for resource: %s", err) | ||
| } | ||
|
|
||
| // log.Printf("========================== Maintenances") |
There was a problem hiding this comment.
nit: would you mind remving the commented out code when you're ready for this to be merged?
| "strconv" | ||
| "strings" | ||
|
|
||
| "github.com/hashicorp/terraform/helper/schema" |
There was a problem hiding this comment.
Can you change this to use github.com/hashicorp/terraform-plugin-sdk/helper/schema?
| "log" | ||
| "strconv" | ||
|
|
||
| "github.com/hashicorp/terraform/helper/schema" |
There was a problem hiding this comment.
Can you change this to use github.com/hashicorp/terraform-plugin-sdk/helper/schema?
| windowParams.From = v.(int64) | ||
| } | ||
| if v, ok := d.GetOk("to"); ok { | ||
| windowParams.To = v.(int64) |
There was a problem hiding this comment.
I get a panic on this line: panic: interface conversion: interface {} is int, not int64. I think this and the from param should probably be changed to int as the terraform SDK only has TypeInt.
|
My bad @russellcardullo @dchancogne I didn't have time to work on it at all. Prefer #98 |
FIX : #62
Signed-off-by: Nicolas Lamirault [email protected]