Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test byte conversion #1771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test byte conversion #1771

wants to merge 1 commit into from

Conversation

Geal
Copy link
Collaborator

@Geal Geal commented Jul 26, 2024

No description provided.

Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #1771 will improve performances by ×2

Comparing test-byte-conversion (b277aa1) with main (f87d397)

Summary

⚡ 4 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark main test-byte-conversion Change
json canada 79.7 ms 69 ms +15.45%
json canada verbose 96 ms 68.4 ms +40.34%
json verbose 28.1 µs 25.1 µs +12.03%
number 244.2 ns 121.9 ns ×2

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.43%. Comparing base (2560d5c) to head (b277aa1).
Report is 2 commits behind head on main.

Files Patch % Lines
src/number/mod.rs 33.33% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   61.47%   61.43%   -0.04%     
==========================================
  Files          24       23       -1     
  Lines        2951     2974      +23     
==========================================
+ Hits         1814     1827      +13     
- Misses       1137     1147      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant