Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing fixes, streaming reads, v2 support #3

Open
gnuish opened this issue Apr 11, 2018 · 2 comments
Open

Parsing fixes, streaming reads, v2 support #3

gnuish opened this issue Apr 11, 2018 · 2 comments

Comments

@gnuish
Copy link
Contributor

gnuish commented Apr 11, 2018 •
edited
Loading

Hello, your project is great for tzfiles and I made some adaptations if you want them. Please let me know if you are interested and would like me to form PRs.

https://github.com/gnuish/zoneinfo-compiled/commits/dev
@ogham
Copy link
Collaborator

ogham commented May 26, 2018

Hi! I’m glad someone is making use of my code. I’d really appreciate PRs if you have the time to make them.

@gnuish
Copy link
Contributor Author

gnuish commented May 27, 2018

Ok, going to make it as a series. I will send subsequent parts if they are dependent on the previous so minimal headaches :p

p1: style, typo
p2: don't carry invalid magic str bytes in error
p3: leap second handling
p4: switch from Cursor to any Reader
p5: 64-bit v2 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ogham @gnuish