Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered markdown gets images from the wrong place #242

Open
eira-fransham opened this issue Jul 4, 2018 · 0 comments
Open

Rendered markdown gets images from the wrong place #242

eira-fransham opened this issue Jul 4, 2018 · 0 comments
Labels

Comments

@eira-fransham
Copy link
Contributor

eira-fransham commented Jul 4, 2018

This isn't really fixable without adding a "URL prefix" option to comrak::ComrakOptions. This is essentially how GitHub gets relative-path images from the right place in its rendered markdown. Alternatively, we can add a map method to comrak::arena_tree::Node and then map it that way (since we want images to have a prefix but not links). I'll put in a PR and then put a PR to this when that gets merged.

@nrc nrc added the bug label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants