Reference parameters inside the format! string (format!("package '{name}'...)

[shnaramn]

          nit: saying this just because I already made another comment but feel free to reference these inside the `format!` string (`format!("package '{name}'...`)

Originally posted by @epage in #12766 (comment)

[shnaramn]

I'd like to fix this if approved.

[Rustin170506]

Sounds good. You can give it a shot :(

[epage]

If you want to refactor the existing code to do the inline parameters, then go for it.

There is a clippy lint for it to help guide the work (or have --fix do it for your). Unsure how everyone feels about merging a stylistic lint being enabled. It would help catch review feedback earlier in the process. We only enable lints in select crates (I think its just cargo lib crate?). until #12178.

[weihanglo]

I would recommend we wait until #12178 gets landed, and adjust lint rules gradually. And it's getting closer!

[weihanglo]

Going to close this as it is a general clippy fix. We don't need a dedicated issue for this specific review comment #12766 (comment).

Despite that, #12178 has been merged, so feel free to open a PR to update. And let's see how enormous the patch will be.