Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output with invalid routing query #9537

Open
breathx opened this issue Sep 28, 2024 · 1 comment
Open

Incorrect output with invalid routing query #9537

breathx opened this issue Sep 28, 2024 · 1 comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@breathx
Copy link

breathx commented Sep 28, 2024

Current Behavior

If you go crates.io/users/$USERNAME?page=N,
where N > $USERNAME.crates.len() / 10, than output will be empty page, rather then reroute to last page or returning an error.

Expected Behavior

Reroute/show last page/return error.

Steps To Reproduce

No response

Environment

  • Browser: Safari
  • OS:

Anything else?

No response

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-frontend 🐹 labels Sep 28, 2024
@eth3lbert
Copy link
Contributor

I personally lean towards not planning to fix this. The reason is that it shouldn't happen if you're navigating via the frontend UI normally. Also, we plan to migrate to seek-based pagination at some point, which doesn't really have a page number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

3 participants