-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion from log::kv::Value
to Option<Vec<String>>
#535
Comments
…nd optimization (rust-lang#535) * Refactor: Extract new crate binstalk-types * Optimize: Rm field `CrateInfo::other` which also removes dep serde-tuple-vec-map and serde-json from binstalk-types. This also makes `CrateInfo` easier to use, more generic and can be used over any `Serializer`, not just `serde_json::Value`. * Mark all errors in `binstalk-manifests` as non_exhaustive * Reduce size of `CvsParseError` by using `Box<str>` instead of `String` for variant `UnknownSourceType`. * Reduce size of `CratesTomlParseError` to 16 bytes on 64bit platform by boxing variants `TomlWrite` and `CvsParse` as these two fields are significantly larger than other variants. * Unify import style in mod `binstall_crates_v1` * Replace dep binstalk-manifests with binstalk-types in binstalk-downloader to reduce its transitive dependencies and enables binstalk-downloader to be built in parallel to binstak-manifests. * Replace dep binstalk-manifests with binstalk-types in binstalk to reduce transitive dependencies and enables binstalk to be built in parallel to binstalk-manifests. This is benefitial because binstalk-manifests pulls in toml_edit, which could takes up to 15s to be built on M1 (7-9s for codegen). * Add dep binstalk-manifests to crates/bin * Update dependabot and GHA release-pr Signed-off-by: Jiahao XU <[email protected]>
This is quite a useful thing to be able to do, and is currently a feature gap in We could try come up with an API that makes sense for |
For what it's worth, issue #641 inquires about a more generic way to solve this and other similar conversion needs. |
Hello!
I am implementing a custom logger that prints a JSON serialized struct. The struct has a field
custom_list: Option<Vec<String>>
that should be derived fromlog::kv::Value
. However I could not figure out how to convert toVec<String>
fromValue
? Is that a missing feature or am I overseeing something here?From end users perspective:
info!(custom_list = as_serde!(vec!["a".to_string(), "b".to_string()]); "Test log msg");
Thanks
The text was updated successfully, but these errors were encountered: